nickpadd / EuropeanFootballLeaguePredictor

A machine learning/statistical model to derive prediction probabilities for football matches of the top european leagues.
https://nickpadd.github.io/EuropeanFootballLeaguePredictor/Home.html
MIT License
36 stars 8 forks source link

Setting up the project #84

Closed MichaHllx closed 1 week ago

MichaHllx commented 1 week ago

First pull request

Creation of a batch script (.bat) that runs under Windows using the command prompt (not for PowerShell, possible improvement). Creation of a bash script (.sh) that runs on Linux and macOS. This script works with the zsh shell and the bash shell.

Advantages

Possible improvements to my contribution

In conclusion, I think and hope that this contribution will solve some of the problems that users had. In any case, I think it will help users who are less at ease with the domain. And I also hope that it will make maintenance work easier afterwards for the developer.

Second pull request (based on maintainer suggestions)

Here are changes made from suggestions of the maintainer about my last pull request:

✅ changed name of both scripts (from PROJECT-SETUP to run_project_setup)

✅ do not manage repository cloning in both scripts

✅ added git cloning instructions to the Readme

Final pull request for setting up the project

Improved bash script for better management of checking installed python versions.

nickpadd commented 1 week ago

Everything looks great now.! Merging this PR—appreciate your effort and collaboration!