Closed mrenoch closed 3 years ago
Merged, thanks so much!
Sure thing. Thanks for bringing this into the world!
I'm not sure where you might be having a conversation around what's next, but if you did want folks to run their own instances of this, you are like half an hour away from the deploy to heroku button - https://blog.heroku.com/six-strategies-deploy-to-heroku#the-39-deploy-to-heroku-39-button - which would let folks run easily this in their own heroku accounts w/ their own keys.
Before doing this you might want to improve attribution, so that the website, and possibly the image and it's metadata, credited the original bernie-sits projects.
Folks clearly love this, and will be forking it to overlay arbitrary images. Worth thinking about the role you might want to play in that.
cheers!
Heroku deploy button is a great idea! Added. I mentioned a strategy I have in mind for arbitrary image overlays in https://github.com/nicksawhney/bernie-sits/pull/8 thoughts?
I'm thinking we maintain a relatively original-looking version of the site, and have another branch where we can go absolutely wild with everything people want to contribute -- styling, different images and overlays (like people have been asking for on twitter), changing image placement, all the rest! That version could become a more general open-source web based meme creation app. Would love anyone's thoughts!
Hi,
I made a fresh PR, since my last was made through the web and this seemed simpler. If you are actively working on this now, feel free to just take any of my copy.