nickschot
commented
1 year ago Hiya! Yes indeed, I had converted the add-on to a mono repo kind of early on to separate the (addon-docs) docs etc. app from the add-on code which started to be complex to maintain.
I think the time is now ripe for a proper v2 add-on though.
There is no reason really that this add-on would still require sass or nesting. This was mostly to provide the option (when the host app uses ember-cli-sass) to import and customise it from there. The add-on also ships compiled CSS.
I think we can still provide customisation through css variables as a potential alternative for that.
What I'd like to do is ship the current pre-release as a stable release first, since it fixes the build for existing apps. Help with v2 conversion is of course appreciated.
If you have a strict no-v1 addons policy, we may also need to convert https://github.com/nickschot/ember-gesture-modifiers which is used internally. That should be straightforward though, since it really only has 1 modifier and some test helpers.
NullVoxPopuli
I'd like to use ember-mobile-menu over at ember-primitives.pages.dev/, but I have a strict no-v1 addons policy (except for
@ember/*andember-sourcern).It kind of looks like this repo may be mid-process with converting to v2?
Though, I noticed there is still sass -- which is a deal breaker -- https://github.com/nickschot/ember-mobile-menu/issues/73
Do you want help with v2-ification? I think that way I can
await importthe whole mobile menu unless the screen is of a certain size, which means I can include the mobile menu at all times, but not pay for it on desktop screen sizes!