search

nickslick03 / messiah-meal-planner

1 stars 0 forks source link

Sorting modal and icons #15

Closed cdrice26 closed 4 months ago

cdrice26 commented 4 months ago

Added support for the sorting modal and buttons with icons.

nickslick03 commented 4 months ago

Icons and sorting modal look great! I did notice that the state in the sorting modal would persist when "cancel" was hit so I re-configured the state management between the AvailableMeals and SortingModal components so that AvailableMeals passes its state to SortingModal. This is partly due to me not including a value attribute for the Select component so I added that. I also removed the "select column...", it seemed unnecessary since the location column is the actual default sorted column. Let me know what you think!

cdrice26 commented 4 months ago

Alright I made a few quick changes just to correct a few errors TS was throwing and to move a few things around to make the organization stronger. Good catch on the persistent state, that was intentional because otherwise it would drop even with the confirm button but I forgot to test behavior with cancel, the value attribute on the Select component fixes all of this. Yes, the select column... thing is unnecessary, I found out it was needed for the custom meal add modal (at least without the select value prop) and then immediately went to it being necessary everywhere when it really wasn't. I'm good to merge anytime.