nickslick03 / messiah-meal-planner

1 stars 0 forks source link

Results section #17

Closed nickslick03 closed 1 month ago

nickslick03 commented 1 month ago

Created Results.tsx and ResultsBar.tsx

cdrice26 commented 1 month ago

I made a few changes, let me know what you think and let me know if you want me to undo any of them - here's what I changed:

nickslick03 commented 1 month ago

All the changes look great! I made a few tweaks to the underlying implementation, the big one being I replaced the complex logic for calculating when the scroll reached the bottom in the ResultsBar with an Intersection Observer. Also, the starting balance metric can be hidden with just tailwind classes. Take a look and merge if you think it's ready.

cdrice26 commented 1 month ago

Ok cool! I didn't even think about using CSS to hide the starting balance, that's definitely cleaner! Also never used IntersectionObserver but it definitely makes the code more readable and as a bonus, avoids more of the jankiness on mobile. I'm going to merge.