search

nickspoons / vim-cs

Official Vim Runtime Files for C#
9 stars 3 forks source link

Allow whitespace in auto-implemented property definitions #27

Closed dkearns closed 2 years ago

dkearns commented 2 years ago

Allow whitespace before the following semicolon when matching get/set.

E.g. { get ; set ; }

Also match the newish init keyword introduced in 9.0.

dkearns commented 2 years ago

I'm not sure what your testing philosophies are but by some measures this could be considered a pointless explosion in tests. Let me know if you want some of them merged.

One of the irritating things about Vader is just reports the test failure not the location. I think there's a branch in the Vader repo to address this but I haven't tried it and IIRC the maintainer doesn't want to merge it.

nickspoons commented 2 years ago

Thanks @dkearns. I'm not fanatical about tests. This is good, it gives a lot of tests but as you say, they're ready to debug when something fails. The important thing is that we can see and verify all the forms we want to allow. I agree that this Vader issue is a nuisance though.

dkearns commented 2 years ago

Done. Do you consider using motions rather than explicit line/column numbers the way forward?

nickspoons commented 2 years ago

Do you consider using motions rather than explicit line/column numbers the way forward?

No, not necessarily. In some cases it's clearer than counting character positions, but as soon as there are more than a couple of positions to test it can become harder to read.