search

nickstenning / honcho

Honcho: a python clone of Foreman. For managing Procfile-based applications.
http://pypi.python.org/pypi/honcho
MIT License
1.59k stars 145 forks source link

Fix GH-101 by adding sleep to es job #102

Closed msabramo closed 9 years ago

msabramo commented 9 years ago

Fixes: GH-101

which are intermittent test failures caused by a race condition. I have not seen one of these failures since making this change.

https://github.com/nickstenning/honcho/issues/101

nickstenning commented 9 years ago

I'd rather we just stripped back the integration tests. Would you be up for doing that?

I know removing tests sounds like a bad idea, but having worked on honcho for a while now I can tell you that we need more unit tests and fewer insane and brittle integration tests.

msabramo commented 9 years ago

Yup, see https://github.com/nickstenning/honcho/pull/118