search

nickstenning / honcho

Honcho: a python clone of Foreman. For managing Procfile-based applications.
http://pypi.python.org/pypi/honcho
MIT License
1.59k stars 145 forks source link

GH-103: Add newlines to EOF for upstart templates #107

Closed msabramo closed 9 years ago

msabramo commented 9 years ago

Fixes: GH-103

nickstenning commented 9 years ago

You were right that master.conf and process_master.conf were missing newlines at the end of file, but you've added a whole extra line to these files now. It doesn't really matter, and I'll happily merge this, but do note the difference between "file ends with a newline" and "file ends with a blank line and a newline".

msabramo commented 9 years ago

Oh maybe I can update then.

msabramo commented 9 years ago

Actually just looked at this and think there is no problem. Yes, it's true that I've edited the templates so that each "file ends with a blank line and a newline". However, when the template is rendered into an output file, there is no blank line at the end of the generated file. And if I remove the blank line in the template, then the generated file ends up with no newline on its last line.

This is confusing I guess, so maybe we should think about removing the blank final line from the templates and changing the Python code to emit a final newline if it's not there. That way, if people write or edit templates, they don't have to know to add a blank line to the end, which is somewhat unexpected.

msabramo commented 9 years ago

Closing in favor of https://github.com/nickstenning/honcho/pull/116