Default port behavior differs from Foreman

nickstenning / honcho

Honcho: a python clone of Foreman. For managing Procfile-based applications.

http://pypi.python.org/pypi/honcho

MIT License

1.59k stars 145 forks source link

Default port behavior differs from Foreman #123

Closed joeyespo closed 9 years ago

joeyespo commented 9 years ago

I was trying to use Honcho and Python 3 because Foreman was buggy with file handling, and I noticed some differences.

I set up this gist to test and demonstrate the differences:

Foreman's port precedence is -p option, .env file, PORT variable, default of 5000
Honcho's port precedence is .env file, PORT variable, -p option, default of 5000

slafs commented 9 years ago

Hi!

Thanks for raising an issue and for a great gist!

I see that the bug itself doesn't have anything to do with python3. It's there on both python2 and python3. Also after running your script from the gist it seems that PORT variable has a higher precedence than -p option as well.

joeyespo commented 9 years ago

No prob! Yeah, I mentioned Python3 just in case. I tested on Python 2 too and saw the same thing.

Ah yes, you're right. I mixed up -p and PORT in the description up there. Fixed. Thanks!

nickstenning commented 9 years ago

Thank you for the report. Fixed by e0838bb and released as v0.6.3.