Closed msabramo closed 9 years ago
OK, I added a couple of simple unit tests in 6a5a97f.
@nickstenning, @slafs: Please review when you get a chance.
Hey, sorry to bother, I wonder if I can do anything to move this along, as we are planning a project at work where we want to eliminate dozens of manually-curated supervisor config files and replace them with Procfile
s and a process that automatically generates the supervisor configs.
I will probably need this for that task.
Hi @msabramo! I'm little busy right now. Will take a look at this on weekend if I have some time.
@nickstenning: Do you have time to look at this? If not, that's fine -- though I may need to devise a solution for generating supervisor configs that doesn't use honcho and I'd rather use honcho if possible, as it works nicely and looks like foreman so it's more familiar to some people, etc.
Cc: @sudarkoff
@nickstenning: Thanks for the review! Addressed your comments and I do think it's easier to understand now. Let me know what you think.
Great! I've cleaned up a couple of bits and pieces and merged this as 5886e1849cd6690883b3a08b2143d2e4e52cb497. Thanks Marc!
Thanks you too for the great feedback and for open sourcing honcho in the first place!
Feature available in Honcho 0.6.5: https://pypi.python.org/pypi/honcho/0.6.5
This is a honcho analogue of the corresponding options to
foreman export
-- See:This lets you specify a custom Jinja template to be used when exporting to a supervisord config file.
Fixes: GH-88
See: https://github.com/nickstenning/honcho/issues/88
OK, I just updated this so that
--template
is a directory. I'm not quite sure how to test this in an automated way, but I did do manual testing.