search

nickstenning / honcho

Honcho: a python clone of Foreman. For managing Procfile-based applications.
http://pypi.python.org/pypi/honcho
MIT License
1.6k stars 146 forks source link

Fix a bug when honcho silently ignores environment file #148

Closed azov closed 9 years ago

azov commented 9 years ago

If Procfile is not located in the app root directory honcho uses incorrect path and silently ignores the error. The fix is to pass app_root directly to _read_env instead of deriving it from procfile_path

slafs commented 9 years ago

Hey! Thanks for the PR. The thing with silently ignoring env file is at least debatable (I mean raising CommandError). As you can see the build is red probably because of that. Maybe we could split those two issues in two seperate PRs? There's also a small linting issue with procfile_path.

azov commented 9 years ago

Okay, how about just logging a warning then? As long as it's not silent I don't have an opinion on whether it should raise or not.

slafs commented 9 years ago

Yeah, let's try not to raise an error for now.