Fix a bug when honcho silently ignores environment file

nickstenning / honcho

Honcho: a python clone of Foreman. For managing Procfile-based applications.

http://pypi.python.org/pypi/honcho

MIT License

1.59k stars 145 forks source link

Fix a bug when honcho silently ignores environment file #149

Closed azov closed 8 years ago

azov commented 9 years ago

If Procfile is not located in the app root directory honcho uses incorrect path and silently ignores the error. The fix is to pass app_root directly to _read_env instead of deriving it from procfile_path

slafs commented 9 years ago

Ok. Now we should probably discuss if this is really a bug or a feature. It actually looks like a regression because in 0.5.0 the behavior is different. Personally I don't recall anyone changed this on purpose but maybe @nickstenning could write a word or two. :+1: from me.

nickstenning commented 8 years ago

Cheers. I think this was indeed an unintended regression. Sorry it's taken so long to get round to merging it.