Allows `python -m honcho` to act the same as `honcho` (#199).

nickstenning / honcho

Honcho: a python clone of Foreman. For managing Procfile-based applications.

http://pypi.python.org/pypi/honcho

MIT License

1.6k stars 146 forks source link

Allows `python -m honcho` to act the same as `honcho` (#199). #202

Closed hartym closed 5 years ago

hartym commented 6 years ago

Few points here:

I was a bit reluctant to add that much testing for a 3 line patches, especially because all integration tests are now ran twice, thus doubling their execution time. But I still think this needs to be tested, so I'm open to ideas for shortening the tests implementation.
Maybe there is a way to have a "parametrized-fixture" thing in pytest?
Should I add something in documentation?

hartym commented 6 years ago

(py 2.6 /3.3 failing, will have a look asap)

nickstenning commented 6 years ago

I wouldn't worry too much. If needs be we can probably drop support for 2.6/3.3 at this point.

nickstenning commented 6 years ago

The functional change here looks good to me (__main__.py) but I think the testing regime isn't ideal, as you mentioned.

I'd be inclined to just add a single test -- for example that python -m honcho version returns what we expect. If that works, then the chances of everything else being broken are pretty slim.

And yes, if you could find a suitable place to mention this in the docs too, that would be great.

nickstenning commented 5 years ago

Thanks for the idea! This functionality has been merged in #209.