Py3.8 RuntimeWarning: line buffering isn't supported in binary mode

[oTree-org]

On Python 3.8 (not 3.7) & Windows (not Mac), I get this warning with the latest Honcho (1.0.1):

(ve38) C:\oTree\core\tests [prodserver-refactor +1 ~0 -0 !]> python
Python 3.8.3 (tags/v3.8.3:6f8c832, May 13 2020, 22:37:02) [MSC v.1924 64 bit (AMD64)] on win32
>>> from honcho.manager import Manager
>>> m=Manager(); m.add_process('a','dir')
<honcho.process.Process object at 0x000002A7C0120970>
>>> m.loop()
C:\Users\wicke\AppData\Local\Programs\Python\Python38\lib\subprocess.py:844: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used
  self.stdout = io.open(c2pread, 'rb', bufsize)

[kronion]

This is not a Windows-specific issue. I see the same warning on Mac (Python 3.8).

The underlying cause has already been resolved in this commit, it just hasn't been released, along with several other bug fixes.

[jacebrowning]

If you're using Poetry, adding this to pyproject.toml will get you the version containing the fix:

[tool.poetry.dev-dependencies]

honcho = { git = "https://github.com/nickstenning/honcho", rev = "b4de1aa0504d41c0f05efbb04f63c624fccded81" }

[rmehta]

via pip

pip3 uninstall honcho
pip3 install git+git://github.com/nickstenning/honcho.git@b4de1aa0504d41c0f05efbb04f63c624fccded81

[nickstenning]

Closing this issue. I'm in the process of preparing a new release which will contain this fix.