search

nicktrandafil / tags

Tag Input widget for Qt5
MIT License
42 stars 8 forks source link

Wrong order of comparison in mousePressEvent #7

Closed xvallspl closed 2 years ago

xvallspl commented 3 years ago

https://github.com/nicktrandafil/tags/blob/ca30ebcfb350cb74c4b3e70955d43ad7b9d6f983/src/tags_edit.cpp#L305

should be

while (it != end(impl->tags) && it->rect.top() == row) {

or we could access out of bounds, as we are incrementing the iterator

nicktrandafil commented 2 years ago

Fixed