search

nickvanw / ircx

Basic callback-driven Go IRC bot
Apache License 2.0
37 stars 13 forks source link

ircx: remove logging, add error handling + better retry logic #15

Closed nickvanw closed 9 years ago

nickvanw commented 9 years ago

Addresses #11

Removes all of the superfluous logging and returns errors instead. Also changes how the retry logic works -- instead of a config string, adds a MaxRetries in the Config struct, if it's set to above 0 it will try that many times before returning an error.

cc @alaska and @mvdan -- this is a breaking API change, but I think it's worth it in the long run.

mvdan commented 9 years ago

Otherwise LGTM

mvdan commented 9 years ago

I'd like to do a PR for the callbacks but it would conflict with this one - could you merge? :)

nickvanw commented 9 years ago

@mvdan merged! looking at #16 now!