Bump to using `irc.v2` - Githubissues

nickvanw / ircx

Basic callback-driven Go IRC bot

Apache License 2.0

37 stars 13 forks source link

Bump to using `irc.v2` #32

Closed nickvanw closed 5 years ago

nickvanw commented 5 years ago

Hey @mvdan!

I've got some free time and am doing some cleanup here. It looks like you've been active today as well, so hopefully you're around!

This PR bumps us to using irc v2, which is a breaking change insofar as Trailing goes away. I've bumped the version of this library to v2 as well and will tag it as v2.0.0 when all looks well.

Next, I'll be doing some work on the logging portions of this to get rid of our go-kit dependency and make something significantly more lightweight.

nickvanw commented 5 years ago

I wouldn't use blockquotes in commit messages (nor triple backquotes), as not even GitHub renders commit messages in markdown.

The commits themselves aren't using blockquotes, only the PR title. I know they're not rendered, but I still do it anyway out of habit 😛