search

nickw444 / flask-ldap3-login

LDAP3 Logins for Flask/Flask-Login
http://flask-ldap3-login.readthedocs.org/en/latest/
MIT License
73 stars 38 forks source link

Module is now compatible with ldap3>=2.0.7. #18

Closed cgroschupp closed 8 years ago

cgroschupp commented 8 years ago

Fixed #17

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 90.175% when pulling 5566229358257468799c1f380730c75ffd01fb39 on cgroschupp:feature_ldap3_2_0_7 into fd37d6ddf69f2bfc812cecd47b4397a34f041508 on nickw444:master.

nickw444 commented 8 years ago

Beautiful! Thanks for these changes. Do you think it would be worth pinning the dependency to either ldap3>=2.0.7,<2.1.0 or ldap3>=2.0.7,<3.0.0 to stop this happening again in the future?

Let me know your thoughts, happy to merge without it though.