search

nickw444 / flask-ldap3-login

LDAP3 Logins for Flask/Flask-Login
http://flask-ldap3-login.readthedocs.org/en/latest/
MIT License
73 stars 38 forks source link

Fixes get_user_groups for user dn that must be escaped to be used in … #38

Closed mofrank closed 6 years ago

mofrank commented 6 years ago

…a filter Found a problem with user dn's that have chars that cannot be in a filter. For instance "cn=Firstname (admin) Lastname, ..." causes filters to not work due to the ().

This patch should fix the problem.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.01%) to 96.918% when pulling 83cda66dd49bb473933a0b865dcca6e559540ceb on mofrank:master into 97b6029fbb90d667afff1e698308a6b5b76d371a on nickw444:master.

nickw444 commented 6 years ago

Awesome, thanks for this. Is there any chance you could introduce a new test to ensure this functionality is working as expected?

nickw444 commented 6 years ago

This PR will be merged as part of https://github.com/nickw444/flask-ldap3-login/pull/42 which adds tests