search

nickw444 / flask-ldap3-login

LDAP3 Logins for Flask/Flask-Login
http://flask-ldap3-login.readthedocs.org/en/latest/
MIT License
73 stars 38 forks source link

Solve WTForms 3.0 validators.Required dependency issue #96

Closed northwestwitch closed 3 years ago

northwestwitch commented 3 years ago

Fix #75. Same changes suggested by @HeMan. Tested locally and it works fine!

shortywz commented 3 years ago

Are we going to be able to get this PR merged, or are we still waiting for a new maintainer?

nickw444 commented 3 years ago

Merged, yes I can do that. As for releasing it, I'd like to get either @HeMan or @gmacon to advise because as I understand, master contains unreleased breaking changes which were intended to land in v1.0.x.

nickw444 commented 3 years ago

I think the best way forward (given the slowdown on v1 progress) will be to move master to a new branch (v1) and roll master back to reflect the current released version and apply patches to both branches as they come through. What do you think @gmacon @HeMan ?

gmacon commented 3 years ago

I think we should just merge this and then release the current state as v1.0.0. The remaining items look fairly minor even though they are technically backwards-breaking. If we write good release notes, we shouldn't scare people off from taking the breaking changes.