nickwph / firebase-app-distribution-action

A very optimized version of Github Action that does the job fast.
MIT License
2 stars 3 forks source link

error: missing required argument 'release-binary-file' #7

Open ninovanhooff opened 5 days ago

ninovanhooff commented 5 days ago

Not sure where the error error: missing required argument 'release-binary-file' comes from, and haven't found that arg in the codebase of this action or in the CLI docs: https://firebase.google.com/docs/app-distribution/android/distribute-cli

By looking at the earlier artifact-step, whe can see that the path /Users/runner/work/Museumvereniging.Android/Museumvereniging.Android/app/build/outputs/apk/prod/release/app-prod-release.apk exists and is passed as an unnamed arg to the firebase cli.

What's going wrong here?

Run actions/***-artifact@v4
  with:
    name: Museumvereniging.Android-3-prod-release-apk
    path: /Users/runner/work/Museumvereniging.Android/Museumvereniging.Android/app/build/outputs/apk/prod/release/app-prod-release.apk

    if-no-files-found: warn
    compression-level: 6
    overwrite: false
    include-hidden-files: false
With the provided path, there will be 1 file ***ed
Artifact name is valid!
Root directory input is valid!
Beginning *** of artifact content to blob storage
Uploaded bytes 3781790
Finished ***ing artifact content to blob storage!
SHA[2](https://github.com/Q42/Museumvereniging.Android/actions/runs/11324974142/job/31490887034#step:5:2)56 hash of ***ed artifact zip is 1e8474e528[3](https://github.com/Q42/Museumvereniging.Android/actions/runs/11324974142/job/31490887034#step:5:3)0feda3914b305b89ad28cf1f4bbbef20e9b64cb7daa1052987d73
Finalizing artifact ***
Artifact Museumvereniging.Android-3-prod-release-apk.zip successfully finalized. Artifact ID 2052398985
Artifact Museumvereniging.Android-3-prod-release-apk has been successfully ***ed! Final size is 3781790 bytes. Artifact ID is 2052398985
Artifact download URL: *****
18s
Run nickwph/firebase-app-distribution-action@v1
Run actions/cache@v3
Cache not found for input keys: firebase-tools
Run echo '***
Run if ! command -v firebase &> /dev/null; then
-- Checking for existing firebase-tools on PATH...
-- Checking your machine type...
-- Downloading binary from https://firebase.tools/bin/macos/latest

######################################################################## 100.0%#=#=#                                                                          
##=#=#                                                                         
##=O#- #                                                                       

                                                                           0.0%
#                                                                          2.2%
#####                                                                      7.[5](https://github.com/Q42/Museumvereniging.Android/actions/runs/11324974142/job/31490887034#step:5:5)%
########                                                                  12.0%
###########                                                               1[6](https://github.com/Q42/Museumvereniging.Android/actions/runs/11324974142/job/31490887034#step:5:6).6%
###############                                                           21.2%
##################                                                        25.9%
#####################                                                     30.3%
########################                                                  34.5%
############################                                              39.4%
#################################                                         46.[7](https://github.com/Q42/Museumvereniging.Android/actions/runs/11324974142/job/31490887034#step:5:7)%
####################################                                      51.2%
#######################################                                   55.4%
###########################################                               59.9%
##############################################                            64.4%
#################################################                         69.0%
####################################################                      73.5%
########################################################                  7[8](https://github.com/Q42/Museumvereniging.Android/actions/runs/11324974142/job/31490887034#step:5:8).0%
############################################################              83.3%
#################################################################         [9](https://github.com/Q42/Museumvereniging.Android/actions/runs/11324974142/job/31490887034#step:5:9)1.5%
######################################################################    97.7%
######################################################################## [10](https://github.com/Q42/Museumvereniging.Android/actions/runs/11324974142/job/31490887034#step:5:11)0.0%
-- Setting permissions on binary...
-- Checking your PATH variable...
-- firebase-tools@13.22.0 is now installed
-- All Done!
Run $(which firebase) appdistribution:distribute \
  $(which firebase) appdistribution:distribute \
    --app ***
   \
    --token "" \
    --release-notes "" \
    --release-notes-file "" \
    --testers "" \
    --testers-file "" \
    --groups "" \
    --groups-file "" \
    $(false && echo "--debug" || echo "") \
    /Users/runner/work/Museumvereniging.Android/Museumvereniging.Android/app/build/outputs/apk/prod/release/app-prod-release.apk
  shell: /bin/bash --noprofile --norc -e -o pipefail ***0***
  env:
    GOOGLE_APPLICATION_CREDENTIALS: /Users/runner/work/_temp/credentials.json
error: missing required argument 'release-binary-file'
Error: Process completed with exit code [1](https://github.com/Q42/Museumvereniging.Android/actions/runs/11324974142/job/31490887034#step:6:1).
ninovanhooff commented 4 days ago

This error seems to come from the default argument: https://github.com/search?q=repo%3Afirebase%2Ffirebase-tools%20release-binary-file&type=code

Perhaps this part throws it off? $(false && echo "--debug" || echo "") \, resolving to an extra space or something like that?