search

nickytonline / astro-partykit-starter

https://astro-partykit-react-starter.netlify.app
8 stars 7 forks source link

Bug: username and room ID not using default values #36

Closed nickytonline closed 9 months ago

nickytonline commented 10 months ago 
          I updated how we were getting the username and room id here because I was running into issues where the app wasn't working because of missing params. So added an explicit check for null and an empty string and that seemed to work.

Here is a video of the problem in production

https://github.com/nickytonline/astro-partykit-starter/assets/67210629/de48a4a5-fc8a-459f-a81d-b21f04bdb7fb

_Originally posted by @jdwilkin4 in https://github.com/nickytonline/astro-partykit-starter/pull/35#discussion_r1450736993_

github-actions[bot] commented 10 months ago

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take".

For full info on how to contribute, please check out our contributors guide.