nickytonline / astro-partykit-starter

https://astro-partykit-react-starter.netlify.app
8 stars 7 forks source link

Feature: add Vitest to the project #40

Closed nickytonline closed 2 weeks ago

nickytonline commented 8 months ago

Add Vitest to the project, so that the starter kit has a testing framework in place.

Things to be done:

github-actions[bot] commented 8 months ago

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take".

For full info on how to contribute, please check out our contributors guide.

adiati98 commented 8 months ago

Love the idea of adding a test! Just out of curiosity, @nickytonline, is there any reason to choose Vitest instead of Playwright or anything else?

Also, I always want to learn about test. I'm interested in working on this, but it might take me some time and some back and forthπŸ˜… So, if it does have a tight deadline, I'll pass it to someone else. 😊

nickytonline commented 8 months ago

Playwright is for end to end tests and component tests. Vitest is like Jest, for writing unit tests, and component tests (if not testing components in Playwright).

jdwilkin4 commented 8 months ago

So, if it does have a tight deadline, I'll pass it to someone else

It doesn't seem like there is a tight deadline here so you should work on it @adiati98 if you are interested πŸ˜„

adiati98 commented 8 months ago

So, if it does have a tight deadline, I'll pass it to someone else

It doesn't seem like there is a tight deadline here so you should work on it @adiati98 if you are interested πŸ˜„

Thanks, @jdwilkin4! I'll .take it then πŸ˜„

github-actions[bot] commented 8 months ago

The issue you are trying to assign yourself is blocked until it can be triaged or by another label on the issue.

nickytonline commented 8 months ago

If you need any assistance, happy to help.

adiati98 commented 8 months ago

If you need any assistance, happy to help.

I'll let you know! Thanks, Nick.

adiati98 commented 8 months ago

Hey @nickytonline @jdwilkin4 @Satoshi-Sh,

I've worked on this. And for some reason, I can't push my changes to remote repo. Below is the screenshot of the error.

error: failed to push some refs

I've tried git push -u origin feat/install-vites, git push -u upstream feat/install-vites, git pull --rebase upstream main, and git pull --rebase origin main. Nothing works.

Does anyone have similar case? I'm not sure what should I do here.

nickytonline commented 8 months ago

Did you fork the repository @adiati98? As a maintainer you don't need to. I see you're using upstream as your origin which is why I ask. This doesn't explain the erro though. That error usually means that feat/install-vites doesn't exist remotely, i.e. on GitHub.

I also see your using https instead of SSH. Again, I don't think that's the issue, but consider using SSH instead. See https://docs.github.com/en/authentication/connecting-to-github-with-ssh.

Worst case try creating a new branch and see if you end up with the same result.

adiati98 commented 8 months ago

Thanks, @nickytonline. After debugging on Slack, I found out that I missed a letter in my branch name when I pushed it. πŸ˜…

Now all is good.