search

nicm / fdm

fdm source code
269 stars 50 forks source link

Adjust mremap(2) call for NetBSD #59

Closed iamleot closed 5 years ago

iamleot commented 5 years ago

mremap is recognized in the configure phase on NetBSD but it fails to build due incompatibilities.

On NetBSD MREMAP_MAYMOVE flag is the default behaviour (and such flag don't exist) and mremap(2) has an extra argument compared to the glibc one.

nicm commented 5 years ago

Thanks - mremap is not essential so I decided to just to skip using mremap where MREMAP_MAYMOVE is not defined. Please let me know if you see any problems.

iamleot commented 5 years ago

Nicholas Marriott writes:

Thanks - mremap is not essential so I decided to just to skip using mremap where MREMAP_MAYMOVE is not defined. Please let me know if you see any problems.

That's not a problem (and that's what it was done in pkgsrc previously) but - out of curiosity - why just skip it instead of adjusting as proposed?

Thank you!

nicm commented 5 years ago

I prefer a general test in configure than platform-specific defines in C code, and it is neater to check for a single define that try to work out if there is a function with the same name but different arguments.

NetBSD have an awful habit of doing this and it just makes unnecessary work for everyone else...

krytarowski commented 5 years ago

Well, the NetBSD version is much cleaner. Linux one is hack and got this .... added in more recent kernels.. It's not something to clone to others.

Rejecting NetBSD support and prioritizing Linux is gross here.