search

nicman23 / dkms-hid-nintendo

dkms-hid-nintendo
GNU General Public License v2.0
235 stars 42 forks source link

Make LEDs optional #47

Closed mnakama closed 3 years ago

mnakama commented 3 years ago

Some 3rd-party controllers do not have Nintendo-style controllable LEDs. One example is the 8BitDo N30 NS Bluetooth gamepad: https://www.8bitdo.com/N30-NS/

This patch allows using the 8BitDo N30 NS (and perhaps other controllers) on linux.

Note: while this does work, I haven't figured out why the controller won't communicate over Bluetooth upon re-connection. Un-pairing and Re-pairing the controller works, though.

nicman23 commented 3 years ago

thanks a lot :)

mnakama commented 3 years ago

np, thanks for merging, and big thanks for making this driver in the first place :smile:

I haven't worked on drivers before, so it took me quite a while to even figure out that I have to rmmod ..., dkms remove ..., and dkms install ... every time I make a change. :sweat_smile:

nicman23 commented 3 years ago

i am not the original author. i just packaged it to a dkms module :)

original source https://github.com/DanielOgorchock/linux

mnakama commented 3 years ago

Oh! My mistake. Should I have done a PR to that tree instead?

nicman23 commented 3 years ago

go for it