search

nicman23 / dkms-hid-nintendo

dkms-hid-nintendo
GNU General Public License v2.0
240 stars 43 forks source link

Add an option to allow ignoring init failures #60

Closed waffshappen closed 2 years ago

waffshappen commented 2 years ago

This should fix a few oddball controllers like 8bitdo and friends to get through init by just ignoring their respective missing Features and errorneous responses while maintaing default correctness for real joycons.

This requires loading the module with modprobe hid-nintendo ignore_init_failure=1

I tested this locally on a 8bitdo Pro 2 and SN30 and they went through init and even played a round with working gyro aim. But because to reconnect without issues in switch mode these seems to require joycond i am going to abandon them going forward. Maybe this helps the many others who have thirdparty controllers - although i've gotten mixed results - i'll not be able to test this going forward as i will be replacing the controllers with a dualsense to spare myself the pain.

nicman23 commented 2 years ago

Look good, only thing before merging that i want is a more severe parameter info text - mostly that it might not work

waffshappen commented 2 years ago

Look good, only thing before merging that i want is a more severe parameter info text - mostly that it might not work

If this isnt severe enough feel free to replace it with an even more drastic one.

nicman23 commented 2 years ago

thanks merged