search

nico3333fr / jquery-accessible-modal-window-aria

jQuery simple and accessible modal window, using ARIA
MIT License
60 stars 20 forks source link

Uncaught ReferenceError: $close is not defined #16

Closed pepemiyashiro closed 8 years ago

pepemiyashiro commented 8 years ago

Hello,

I found this error log. And this is related to the variables declaration on line: 184

var $this = $(this),
      $js_modal = $('#js-modal'),
      focusedItem = $( document.activeElement ),
      in_jsmodal = focusedItem.parents('#js-modal').length ? true : false;
     $close = $('#js-modal-close');

I found that the in_jsmodal assigment end in a semicolon, and it should be a comma.

Shold be like this:

var $this = $(this),
      $js_modal = $('#js-modal'),
      focusedItem = $( document.activeElement ),
      in_jsmodal = focusedItem.parents('#js-modal').length ? true : false,
     $close = $('#js-modal-close');

Hope it helps.

nico3333fr commented 8 years ago

Hi @pepemiyashiro

thanks a lot for pointing it out, I've fixed it.

Kind regards, Nicolas

pepemiyashiro commented 8 years ago

Hi @nico3333fr You are welcome. And thanks for the nice modal plugin you have done.

Thanks you