search

nico3333fr / jquery-accessible-modal-window-aria

jQuery simple and accessible modal window, using ARIA
MIT License
60 stars 20 forks source link

Modal doesn't work in Chrome #5

Closed c0brarules closed 9 years ago

c0brarules commented 9 years ago

Hi Nico,

I hope you are able to translate this properly from English to French.

I appreciate you taking the time to create a simple and accessible modal window, using ARIA. This is something I feel can be very helpful to me.

Unfortunately I cannot seem to get any of the sample pages I have created, based on the code I have either taken from your Demo page here: http://a11y.nicolas-hoffmann.net/modal/ or your GitHub files here: https://github.com/nico3333fr/jquery-accessible-modal-window-aria, to reveal the pop-up modal in Google Chrome.

Here is a sample of the code I have been using http://codepen.io/c0brarules/pen/oXwdZQ based on your demo however the Modal only appears in Internet Explorer and Firefox but does not work in Google Chrome (I'm currently using Google Chrome Version 43.0.2357.124 m).

For some reason your actual Demo page works in Google Chrome though.

Do you know what I need to add to make mine to get it to appear?

Thanks.

nico3333fr commented 9 years ago

Hi,

yes, no problem with english.

It is strange, as it works without problem on Chrome. I've update the sample, could you test ?

Kind regards, Nicolas

c0brarules commented 9 years ago

Hi Nicolas,

Thanks for looking into this for me.

When you say it works without any problems on Chrome, are you referring to your Demo page here: http://a11y.nicolas-hoffmann.net/modal/ or your GitHub files here: https://github.com/nico3333fr/jquery-accessible-modal-window-aria, or the codepen http://codepen.io/c0brarules/pen/oXwdZQ sample I supplied? Which sample were you testing it with?

Please also confirm with me which sample exactly did you update for me to test? The one I included in codepen http://codepen.io/c0brarules/pen/oXwdZQ? If so, it still only displays a transparent gray overlay but no modal box appears in Chrome Version 43.

Thanks again.

nico3333fr commented 9 years ago

Hi,

I've just found where it was coming from : the demo on my page was using a reset for the dialog tag :

dialog {
  display: block;
}

And the problem was here, the sample was missing this information. So it works.

nico3333fr commented 9 years ago

Here is a fix : http://codepen.io/nico3333fr/pen/KpBLZB I'm going to update the sample. Thanks for your patience !