search

nicoalbanese / kirimase

Build full-stack Next.js apps, incredibly fast
https://kirimase.dev
MIT License
2.39k stars 107 forks source link

Enhanced Singular & Plural Conversions Using `pluralize` Library #84

Closed osterkraft closed 7 months ago

osterkraft commented 7 months ago

Thanks for great work on this awesome project @nicoalbanese! This PR addresses an issue with the current singular and plural conversions in the codebase. For instance, creating a categories entity currently results in files like CategorieList.tsx being generated, and leading to inconsistent and often incorrect naming conventions of files, fields and variables.

I propose integrating the pluralize library to resolve this. I've done some basic testing with drizzle and prisma and I haven't run into any issues with this yet. However, further testing is likely needed.

An alternative approach could involve requesting both singular and plural forms via CLI. However, this increases the steps required for input, making the process more cumbersome.

Feedback and suggestions, especially regarding testing and implementation, are highly appreciated.

nicoalbanese commented 7 months ago

This is great! Thanks for pulling this together! Would be great to add a user prompt (at some point in the future) where users are presented the singular version and can confirm it is correct or update it.

Thanks again 😄