search

nicoballarini / SubgrPlots

Graphical displays for subgroup analysis in clinical trials
Other
2 stars 0 forks source link

dependency on retiring spatial infrastructure packages #3

Open rsbivand opened 1 year ago

rsbivand commented 1 year ago

Email April 10:

You will be aware, for example from: https://r-spatial.org/r/2022/04/12/evolution.html, https://r-spatial.org/r/2022/12/14/evolution2.html, https://r-spatial.org/r/2023/04/10/evolution3.html and https://rsbivand.github.io/csds_jan23/bivand_csds_ssg_230117.pdf and perhaps view https://www.youtube.com/watch?v=TlpjIqTPMCA&list=PLzREt6r1NenmWEidssmLm-VO_ YmAh4pq9&index=1 that rgdal, rgeos and maptools will be retired this year, in October 2023.

SubgrPlots Suggests rgeos, which is used unconditionally in 03-venn-diagram-function-areaprop.r, so causing package_functions.Rmd to fail at lines 462-503 (and possibly later). The use seems to be of rgeos::gIntersection(), so you will have to drop it, or re-implement using say the polyclip package (you do not need geographical spatial objects, so sf is probably too large).

You may also use geos and libgeos, from which the operations should match, but beware of a different precision model (rgeos used a fine integer grid, geos may use double precision as default). It should work in the same way, but if there are differences from rgeos, I'd look at precision first.

Please also see https://r-spatial.org/r/2023/04/10/evolution3.html, fix best by June, latest October 2023.

rsbivand commented 1 year ago

@nicoballarini See also https://r-spatial.org/r/2023/05/15/evolution4.html. Please take urgent steps to resolve this issue. No positive changes appear in the repository. Less than three months remain to retain this package on CRAN.

rsbivand commented 11 months ago

@nicoballarini Less than three weeks remain to fix this.

rsbivand commented 11 months ago

@nicoballarini R spatial infrastructure packages maptools, rgdal and rgeos will be archived by CRAN on Monday, October 16, 2023. Your package does not pass CMD check when these packages are not available. Expect your package to be archived by CRAN October 17-18 as CRAN checks feed through and your package fails, if not updated by Monday, October 16, 2023.

No grace period is anticipated, as you have had sufficient time to update your package to remove dependencies on maptools, rgdal and/or rgeos.