nicobrenner / commandjobs

Command Jobs uses AI to help software engineers find the best jobs
Apache License 2.0
146 stars 12 forks source link

Bug: app doesn't work when there's no resume (errors out) #19

Closed nicobrenner closed 3 months ago

nicobrenner commented 3 months ago

There's a line that only runs when entering a new resume, and it should be a simple fix. The error is below

This is an important issue, as it might be preventing anyone new from using the app

Traceback (most recent call last):
  File "/repo/src/menu.py", line 380, in <module>
    curses.wrapper(main)
  File "/usr/local/lib/python3.9/curses/__init__.py", line 94, in wrapper
    return func(stdscr, *args, **kwds)
  File "/repo/src/menu.py", line 376, in main
    app = MenuApp(stdscr, logger)
  File "/repo/src/menu.py", line 75, in __init__
    self.setup()
  File "/repo/src/menu.py", line 109, in setup
    self.run()
  File "/repo/src/menu.py", line 166, in run
    self.handle_keypress(key)
  File "/repo/src/menu.py", line 174, in handle_keypress
    self.execute_menu_action()
  File "/repo/src/menu.py", line 199, in execute_menu_action
    self.manage_resume(self.stdscr)
  File "/repo/src/menu.py", line 264, in manage_resume
    input_lines = self.capture_text_with_scrolling(stdscr, "Enter/Paste your resume. Type 'END' to finish:")
TypeError: capture_text_with_scrolling() takes 2 positional arguments but 3 were given
nicobrenner commented 3 months ago

Great! After fixing that first "simple" error, now I got this other one:

Traceback (most recent call last):
  File "/repo/src/menu.py", line 380, in <module>
    curses.wrapper(main)
  File "/usr/local/lib/python3.9/curses/__init__.py", line 94, in wrapper
    return func(stdscr, *args, **kwds)
  File "/repo/src/menu.py", line 376, in main
    app = MenuApp(stdscr, logger)
  File "/repo/src/menu.py", line 75, in __init__
    self.setup()
  File "/repo/src/menu.py", line 109, in setup
    self.run()
  File "/repo/src/menu.py", line 166, in run
    self.handle_keypress(key)
  File "/repo/src/menu.py", line 174, in handle_keypress
    self.execute_menu_action()
  File "/repo/src/menu.py", line 199, in execute_menu_action
    self.manage_resume(self.stdscr)
  File "/repo/src/menu.py", line 268, in manage_resume
    self.draw_title(stdscr)  # Redraw title after clearing
  File "/repo/src/menu.py", line 141, in draw_title
    title_x = max(0, (max_x - len(title)) // 2)
TypeError: object of type '_curses.window' has no len()

The Plot thickens