Test displaying the resume text #48 Changes made by Aaryamantriescode are:

AaryamanVyas commented 6 months ago

Add tests #25 Dynamic menu now shows "Edit resume" if resume exists. Added tests for managing and displaying resumes. Improved resume management and display functionality in the code.

AaryamanVyas commented 6 months ago

hi @nicobrenner I have tried my best and made something work I think😊. Go through the changes and let me know if anything was wrong !

nicobrenner commented 6 months ago

Hi @aaryamantriescode thank you so much for creating this PR in response to the issue #48

I will now review the changes proposed in the PR and make comments about the changes

This is pretty normal and typical of reviewing code and managing a shared codebase

I will do my best to provide you with proper and useful feedback in a friendly way

Thank you for your time, contributions and understanding

Looking forward to keep building Command Jobs with you

Nico

nicobrenner commented 6 months ago

Ok, @aaryamantriescode just finished reviewing the PR. I really like it overall. I think it's going in a really good direction and would definitely like to incorporate most of the changes

I made some comments about where docker-related files should go in the project, and also would like some clarification about the Visual Studio configuration files for docker

Besides that, there are some minors adjustments for the test file and it should be good to go

Thank you so much, I look forward to seeing this PR added to the codebase

AaryamanVyas commented 6 months ago

Hi @aaryamantriescode thank you so much for creating this PR in response to the issue #48

I will now review the changes proposed in the PR and make comments about the changes

This is pretty normal and typical of reviewing code and managing a shared codebase

I will do my best to provide you with proper and useful feedback in a friendly way

Thank you for your time, contributions and understanding

Looking forward to keep building Command Jobs with you

Nico

Thanks! I would love to build more with you 🤞I am learning a lot and like the project😍

AaryamanVyas commented 6 months ago

Ok, @aaryamantriescode just finished reviewing the PR. I really like it overall. I think it's going in a really good direction and would definitely like to incorporate most of the changes

I made some comments about where docker-related files should go in the project, and also would like some clarification about the Visual Studio configuration files for docker

Besides that, there are some minors adjustments for the test file and it should be good to go

Thank you so much, I look forward to seeing this PR added to the codebase

Oh i didnt realize that VS code docker file was commited to the code , It reccomended me to download it and I thought it would be for my personal computer . can you help me out by explaining which files I need to change?

nicobrenner commented 6 months ago

Ok, @aaryamantriescode just finished reviewing the PR. I really like it overall. I think it's going in a really good direction and would definitely like to incorporate most of the changes I made some comments about where docker-related files should go in the project, and also would like some clarification about the Visual Studio configuration files for docker Besides that, there are some minors adjustments for the test file and it should be good to go Thank you so much, I look forward to seeing this PR added to the codebase

Oh i didnt realize that VS code docker file was commited to the code , It reccomended me to download it and I thought it would be for my personal computer . can you help me out by explaining which files I need to change?

Looking into it, keep the .vscode folder with the two .json files, but move all the docker-related files to the docker/ folder. Then adjust the .json files within .vscode to make sure they reference the docker files in docker/. There should be no docker-related files in the root of the repo

AaryamanVyas commented 6 months ago

Ok, @aaryamantriescode just finished reviewing the PR. I really like it overall. I think it's going in a really good direction and would definitely like to incorporate most of the changes I made some comments about where docker-related files should go in the project, and also would like some clarification about the Visual Studio configuration files for docker Besides that, there are some minors adjustments for the test file and it should be good to go Thank you so much, I look forward to seeing this PR added to the codebase

Oh i didnt realize that VS code docker file was commited to the code , It reccomended me to download it and I thought it would be for my personal computer . can you help me out by explaining which files I need to change?

Looking into it, keep the .vscode folder with the two .json files, but move all the docker-related files to the docker/ folder. Then adjust the .json files within .vscode to make sure they reference the docker files in docker/. There should be no docker-related files in the root of the repo

I am not so sure why its telling me i deleted some files but everything should be in the correct files now

nicobrenner commented 6 months ago

Thank you @aaryamantriescode, I see you moved the Docker-related files to the docker/ folder, that's great

Now please:

make sure that the commands for building and running the app still work correctly with the new docker files (I just tried them and had to make some changes to get them working, also the docker-compose file needs some tweaking, it needs the tty and stdin_open lines as well as this volume - ../:/commandjobs)
remove the .vscode folder, and add and entry for it in .gitignore
remove the requirements.txt file in the root of the repo

AaryamanVyas commented 6 months ago

Thank you @aaryamantriescode, I see you moved the Docker-related files to the docker/ folder, that's great

Now please:

make sure that the commands for building and running the app still work correctly with the new docker files (I just tried them and had to make some changes to get them working, also the docker-compose file needs some tweaking, it needs the tty and stdin_open lines as well as this volume - ../:/commandjobs)

remove the .vscode folder, and add and entry for it in .gitignore

remove the requirements.txt file in the root of the repo

Hi, I have a question. How can I just go back to the original code where I didn't mess up the files, so I can make the changes only to the menu and test menu file.

nicobrenner commented 6 months ago

Hi, I have a question. How can I just go back to the original code where I didn't mess up the files, so I can make the changes only to the menu and test menu file

It's all good, you didn't mess anything up, playing with code is how we learn how things work

Having said that, it might be faster to get a clean PR by starting from the current master branch of commanjobs

Probably the easiest way to do that, is to just git clone the repo (git clone git@github.com:nicobrenner/commandjobs.git) in a different folder, that way you'll get the code exactly as it is now in master

There you can add the changes you want

AaryamanVyas commented 6 months ago

image_2024-03-18_080449331 yeah, I am so lost🥲

nicobrenner commented 6 months ago

Not sure what's going on, I think I had a similar issue the other day. Just tried it in my local and it worked though:

git clone git@github.com:nicobrenner/commandjobs.git commandjobs_new

AaryamanVyas commented 6 months ago

Yeah, it still isn't working for me, I think the best option could be to revert all the commits and start over again.

nicobrenner / commandjobs

Test displaying the resume text #48 Changes made by Aaryamantriescode are: #53