search

nicoburns / blessed-rs

A community guide to the Rust ecosystem
https://blessed.rs
1.17k stars 66 forks source link

Contributing on a regular basis? #21

Closed djc closed 1 year ago

djc commented 1 year ago

If you'd like, I'd be happy to help review changes here? You mentioned on HN:

I want to put together more guidance on how to contribute, and gradually transition this into more of a community maintained model over time, but I haven't had a chance to do this yet.

I could just start watching the repo -- maybe you could set up branch protection so that PRs are required, and I'd have a chance to give feedback.

simonsan commented 1 year ago

As an example workflow:

https://github.com/areweguiyet/areweguiyet#contributing

2022-11-09 07_30_24-Window

Not sure if it would be over-engineering, but they set up their own CLI for that, so it would be easier to add and review things, and also run CI in the end. The CLI might be able to be forked and adapted?

nicoburns commented 1 year ago

@djc I'd absolutely love to have you review on changes. However, I'm somewhat reluctant to gate every change on a review step at this point, simply because the list is so incomplete and it seems to me that keeping friction to making changes and additions low should be prioritised during this initial stage. I'm not usually a "move fast and break things" kind of guy, but it seems appropriate here given that the cost of mistakenly listing a crate is quite low.

Would it be unreasonable to ask you to review the git log post-commit for the time being?

djc commented 1 year ago

Reviewing the git log post-commit would be annoying because I have to remember to go and look. However, if you just want to do PRs I'm fine if you merge them without waiting for my feedback, and I'll give feedback asynchronously.

nicoburns commented 1 year ago

That makes sense. I'll try to start doing that.