search

nicoco007 / BeatSaberCustomAvatars

Beat Saber mod that allows the use of custom player avatars for in-game body presence.
GNU Lesser General Public License v3.0
262 stars 41 forks source link

Some avatar will render with the wrong height for other players when using the Multiplayer Mod #23

Closed HugKitten closed 4 years ago

HugKitten commented 4 years ago

Desktop (please complete the following information):

Describe the bug Some avatars (I was using the "Ooka Miko 2nd Form" avatar and he was using the "Meika Mikoto" avatar) will show properly for the person wearing the avatar, but will display the avatar without the adjusted size to other players. I noticed this when me and my friend and we couldn't see each other correctly. When I pat his head, he would see my hands in his face. When he tries to head pat me, his hands are always below my avatar's height, but wouldn't be in my face. I'm about 5"7 and hes 5"11. Also his avatar has a greater size difference than his height which probably makes it more noticeable on his end. Once we switched to another avatar "Ooka Miko" we found that the height of the avatar was rendered correctly for each other and I saw on his screen what he saw on my screen. (We have the camera plus mod) This may be an issue multiplayer mod itself.

Steps to reproduce Steps to reproduce the behavior:

  1. Set up the multiplayer mod with the mod installer on its read me (and all its required dependencies and such) Use BSIPA version 4.0.3. The installer will include the avatar mod. (Version 5.0.0 beta 7 I believe)
  2. Pick one of the broken avatars ("Ooka Miko 2nd Form" or "Meika Mikoto").
  3. Enable the option to resize the avatar to your height or arm length.
  4. Go into a room with people and ask them where your avatar's head is.
  5. Notice that their hands are usually below your actual avatar's height.

Expected behavior That avatars would display with the correct height

Screenshots Forgot to take any.

Avatars avatars.zip

nicoco007 commented 4 years ago

Thanks for the detailed report! If it's only the other players' avatars that aren't being resized properly, then it's most likely an issue on the multiplayer mod's end. I also noticed that they're asking users to install a non-official build of CustomAvatars in the repo's readme; I'm going to have to ask the author why that's the case and see if any changes that were made there can be integrated into the mod.

HugKitten commented 4 years ago

Alright! Thanks for taking the time to read over the report and everything. I know this issue was likely on the Multiplayer Mod's author. I'm still trying to figure out how it handles player height. I don't really have any experience with unity.

HugKitten commented 4 years ago

I think the issue may be fixed by having the multiplayer mod send avatar scale and use that for the size instead of the way it's currently doing it. It'd also ensure that players looked the same to each other no matter what setting they have on the avatar mod. I think this may require your plugin to be updated and for the Multiplayer Mod's dev to add support and update its networking code. That being said, I don't really know a whole lot about unity or how it handles VR.

nicoco007 commented 4 years ago

I'm going to close this for now since I'm 99% sure this is an issue on Multiplayer's end, but feel free to reopen it if turns out it isn't.