search

nicoco007 / BeatSaberCustomAvatars

Beat Saber mod that allows the use of custom player avatars for in-game body presence.
GNU Lesser General Public License v3.0
262 stars 41 forks source link

Certain Custom Avatars Are Headless to CameraPlus #41

Closed ghost closed 4 years ago

ghost commented 4 years ago

_latest.log on a non-working version _latest.log on a working version Desktop (please complete the following information):

Extra Versioning Info: CameraPlus 4.20 (The standard snow12 build on Beatmods) BeatSaberCustomAvatars Jenkins Build of Commit 9cd38f9 (I got impatient about the floor height adjustment bugfix)

Describe the bug Certain avatars are headless as seen by CameraPlus. An example of this can be seen with: https://modelsaber.com/Avatars/?id=1560290521&pc This is working in release 5.0.0-beta 7, as well as the release used by BeatSaberMultiplayer's install guide, or I'd aim at it being a bug with cameraplus.

Steps to reproduce Steps to reproduce the behavior:

  1. Add and use custom avatar.
  2. Use third person camera in CameraPlus.
  3. Fail to see head.

Expected behavior Avatars should show up normally to the camera.

Screenshots Broken: Hatsune miku, headless besides twintails with the bases surrounded by glowing square outlines. Working: Hatsune miku without the bug, mostly normal with some clipping of physics on a dress. She's got a head attached to the twintails though.

ghost commented 4 years ago

It looks like the broken builds are getting "Type provided must be an Enum" errors on the avatar. That seems to be the primary difference at a glance?

nicoco007 commented 4 years ago

This is actually 2 separate issues. The missing heads are caused by a change to the layers used by the avatars since there were some conflicts with internal Unity and Beat Saber stuff. Since CameraPlus doesn't reference these directly, they'll also have to be updated on its end. The type errors in the log are because of an oversight on my part and have now been fixed.