nicoco007 / BeatSaberCustomAvatars

Beat Saber mod that allows the use of custom player avatars for in-game body presence.
GNU Lesser General Public License v3.0
262 stars 41 forks source link

EveryNthComboFilter doesn't work #55

Closed ranmd9a closed 4 years ago

ranmd9a commented 4 years ago

Before doing anything else, please attach your latest log to this issue. It should be located at Logs\_latest.log in your Beat Saber installation's folder. _latest.log

Desktop (please complete the following information):

Describe the bug I use CustomAvatar.dll of this version. However, the event set in EveryNthComboFilter does not work. (EveryNthComboFilter worked with CustomAvatar.dll 5.0.0 beta7)

Steps to reproduce Steps to reproduce the behavior:

  1. Use an avatar that set EveryNthComboFilter,
  2. Play any song.
  3. 50 combo reached, but the event not fired.

Expected behavior EveryNthComboFilter work.

nicoco007 commented 4 years ago

Good catch! Could you try this version and let me know if it works?

ranmd9a commented 4 years ago

Thank you for your fast response! But when I used that version, the avatar disappeared. (So I can't confirm that it is fixed.)

latest.log is here. _latest.log

I deleted a cameraplus.cfg just in case and started BeatSaber, but the avatar was not shown. And I used DynamicOpenVR 0.2.0 by mistake, but it was the same with 0.2.1.

nicoco007 commented 4 years ago

That's strange. Can you see it in the mirror when in the Avatars menu? I forgot to mention that the version I linked doesn't currently work properly with CameraPlus.

ranmd9a commented 4 years ago

Oh, I can see the avater in Avatars menu. And I confirmed that EveryNthComboFilter works by watching avatar's face reflected on the floor. Thanks. It may be a problem of CameraPlus as you say.

nicoco007 commented 4 years ago

This version should work properly with CameraPlus. Could you try it out?

ranmd9a commented 4 years ago

It works, and the avatar did not disappeare! Thank you so much!