search

nicoduj / homebridge-deebotEcovacs

Homebridge Deebot (from Ecovacs) plugin
The Unlicense
42 stars 3 forks source link

Canvas dependency #64

Closed mrbungle64 closed 2 years ago

mrbungle64 commented 3 years ago

Hi @nicoduj

since version 4.20 of the library canvas is no longer required. I have moved canvas to the optionalDependencies section.

I think that you can remove the warning in your plugin:

"IMPORTANT If you encounter any issue while installing, you might have to install additionnal packages on your environment since the main dependency of it depends on canvas library which is not available for all configurations. See there for more details : canvas compiling..."

nicoduj commented 3 years ago

Hi,

indeed ;) Homebridge / npm still put some warnings for this however during install last time I checked, that is why I wanted to take a look but completely forgot. thanks for putting an issue as a reminder !

nicoduj commented 2 years ago

Removed form changelog (still in readme but with a note that it is not necessary anymore since 1.2.0)