search

nicojeske / RazerAmbilight

Razer Ambilight - A background process that creates an ambilight effect for razer keyboards.
MIT License
39 stars 12 forks source link

Ultrawide Monitor mode for Ambilight #27

Closed stalonium closed 5 years ago

stalonium commented 5 years ago

Added new option "Ultrawide Monitor mode" that shrinks the 21:9 source image used to generate the ambilight down to 16:9 so the ambilight on the keyboard lines up better with the monitor. This is especially helpful when viewing 16:9 content with black bars on the sides so it doesn't also create black bars on the keyboard ambilight.

nicojeske commented 5 years ago

As my first open source project, I never thought people would contribute to my software and actually add good features. I have just reviewed your pull request and the code is well written and perfectly integrated into my naming scheme etc. (which is certainly not the best). I can't really test it because I don't have a 21:9 monitor, but if you look through the code, everything should work as you intended, and I'm confident that you tested it thoroughly yourself. So I will gratefully accept your pull request and integrate your feature into the next version.

Thank you very much for your support!