search

nicojs / node-link-parent-bin

A tool to link the bins of the your npm dependencies to child packages in a node multi-package repository
43 stars 11 forks source link

feat: support log level off #11

Closed Aqours closed 5 years ago

Aqours commented 5 years ago

We can ignore EEXIST 'errors' which does not cause terminal exist, that look like real errors on CI/Linux/macOS platform.

nicojs commented 5 years ago

Maybe we could if we catch and handle the error correctly?

nicojs commented 5 years ago

I think this is the culprit:

https://github.com/nicojs/node-link-parent-bin/blob/44d34396dab44b9d545ef89fd38e03cfb60bed86/src/cli.ts#L17-L18

nicojs commented 5 years ago

Anyway, released. https://github.com/nicojs/node-link-parent-bin/blob/master/CHANGELOG.md#102-2019-07-09

Aqours commented 5 years ago

https://github.com/nicojs/node-link-parent-bin/blob/30bd706e7b90309d3dedd74ab34a2015f6d704aa/src/ParentBinLinker.ts#L50

I think we should override existed bin file or catch EEXIST error and give a warning to user, because these errors does not affect child packages bin file.