search

nicokaiser / hugo-theme-gallery

Gallery Theme for Hugo
https://nicokaiser.github.io/hugo-theme-gallery/
MIT License
371 stars 115 forks source link

feat: Create ja.yaml #66

Closed salixor closed 6 months ago

salixor commented 6 months ago

Adding Japanese support required to change how the "X photos in Y albums" sentence was handled, as Japanese doesn't say it the same way. Let me know if you feel like there's a better way to handle this !

I also took the opportunity to remove lang.FormatNumber as we only ever get integers, and their formatting is language independent.

nicokaiser commented 6 months ago

Thanks for your PR! Could you re-add the lang.formatNumber please? The number formatting is not language independent: it will add a thousands separator, e.g. in German it will show "1.209 Fotos" (instead of "1209 Fotos"), in English it will most probably show "1,209 photos", etc.

The other changes look good!

salixor commented 6 months ago

Oh, indeed ! Thousands separators slipped my mind for some reason. I'm changing this.