search

nicokaiser / rpi-audio-receiver

Raspberry Pi Audio Receiver with Bluetooth A2DP, AirPlay 2, and Spotify Connect
MIT License
1.39k stars 148 forks source link

Several changes and options to build some packages from source #50

Closed hosac closed 4 years ago

hosac commented 4 years ago

I merged my personal experience with some packages with your repo.

nicokaiser commented 4 years ago

I'm not sure. I see two problems with this:

  1. I'd like to keep this script as simple as possible and as close to the default Debian/Raspbian configuration as possible. This involves the use of the supplied binary packages whenever possible, even if these versions may be slightly older (Raspbian gets updated from time to time, so this should not be such a big problem). So adding the whole compile and build stack and pulling and compiling sources from GitHub etc. adds a lot more complexity (and disk usage and installation time) to the project.

  2. I'd really like to preserve the use of the "pretty name" (which is displayed on other devices as the Bluetooth name or the AirPlay/Spotify speaker name). Just using the hostname here does not work for me, as I'd like the device to be visible as "Livingroom" instead as "airpi-livingroom".

hosac commented 4 years ago

Thanks for sharing your thoughts and explanations. My personal opinion is:

  1. I understand that the script should be simple as possible. The reason why I added the option for building gmediarender/upnp is that the current version has some issues with the control elements which makes is useless for me (No time sync of the title, Start/Stop issue).

  2. After first usage of the existing installation script I planned to change the names (hostname and/or pretty name). Bluetooth service is using always the current pretty name of the system and the hostname as fallback and snapclient always the hostname - that's good. The other services are getting the pretty name from config files, which were generated by the installation script. These files must be edited in case of a hostname/pretty change. I personally try to avoid storing system variables in config files. Guess the best solution would be a combination of our thoughts.

It was just a try to support your cool project. Let me know, whether I should change something of my proposals.

VG