search

nicola / isawake

:sunrise: The (eventually) biggest crowdsourced database of people awake, sign up with a pull-request
http://isawake.me
27 stars 25 forks source link

Refactoring #4

Closed framp closed 10 years ago

framp commented 10 years ago

Code cleaning (removed those ugly if elseif) JSLinted (not exactly my kind of thing - but I noticed you were using 4 spaces indentation, multiple var declaration and I assumed you were following Crockford) Added personRange (because not everyone sleeps!)

nicola commented 10 years ago

This is a breaking change, I might have to look at how you fix coloring here! Thanks!

nicola commented 10 years ago

The issue is that you are changing the gradient idea of @mtt84, by replacing it with a flat color.

framp commented 10 years ago

Nothing has been changed actually, I'm still setting the top position of the gradient and the color for the answer.

Merged the latest responsive fix

Screenshot: snapshot51

nicola commented 10 years ago

Thanks a lot for the commit, much nicer code!