search

nicolafan / pyleague-soccer-simulation

A Python soccer championship simulation
MIT License
5 stars 3 forks source link

Standings position colors #4

Open nicolafan opened 2 years ago

nicolafan commented 2 years ago

It would be cool to have the first three teams in the competition having sequentially a gold, silver and bronze color for the square which contains their position in the standings. The last three teams could have red squares which would represent relegation. This is one example of the squares I'm talking about: Screenshot from 2021-12-14 21-50-49

Xander23432 commented 2 years ago

Maybe this feature should be implemented for the final standings after the league finishes.

nicolafan commented 2 years ago

Hi @Xander23432 , thanks for your comment. I looked at some standings and I think it's right: the gold, silver and bronze colors should be added at the end because it could seem like the championship has finished. By the way, in almost all the standings we Have different colors for the first 3-4 teams who are in Champions League positions and red is used for teams in relegati in: Screenshot_2021-12-15-08-09-21-280_eu.livesport.Diretta_it.jpg Screenshot_2021-12-15-08-10-02-118_com.android.chrome.jpg Maybe we could use blue for the first three teams and red for the last three. What do you think?

Also: PyLeague makes it possible to create leagues of 2-4-6-etc teams so these situations should be taken care of.

Xander23432 commented 2 years ago

Hi @nicolafan , I also think that the first 3 or 4 standings should have some different colour as to make it look different than the rest of the teams. It should be done.

nicolafan commented 2 years ago

Hello @Xander23432 , perfect. If you want you can open a PR for this. I'll leave the issue open in case somebody wants to help. Let me know if you want me to assign this to you.