search

nicolafranchini / VenoBox

Responsive Vanilla JS lightbox plugin, suitable for images, videos, iFrames, inline contents
https://veno.es/venobox/
MIT License
680 stars 175 forks source link

VenoBox and ie9 #8

Closed natlee88 closed 10 years ago

natlee88 commented 10 years ago

Hi there, I was just wondering if this works down to ie8? I'm just testing my site on ie9 and VenoBox seems broken.

Thanks :)

nicolafranchini commented 10 years ago

I'm sorry, never tested on IE (I haven't it), I don't know what is wrong with that.. maybe some css3 attributes?

natlee88 commented 10 years ago

Ok thats cool. It's not loading in the iframe in ie9. Im not sure why. Would you know?

lukeburford commented 10 years ago

Also in IE9, does not load or loads the incorrect inline content when there are multiple items on the page. This is a mixture of YouTube embeds and inline HTML.

sdsoregon commented 10 years ago

I can not get anything to display in ie 8 or 9 either.

matthewcarleton commented 10 years ago

yes, neither can I. I need it to work in IE9. Why wouldn't you test in IE at all? I understand not testing in older version but not at all?

nicolafranchini commented 10 years ago

As said before: it's not a choice, i can't, i have no IE on my machine. so, anyone of you who finds a fix is welcome! ;)

matthewcarleton commented 10 years ago

That's too bad, There are some pretty easy ways to get a testing environment set up for IE. Without basic IE support most things are not usable.

dmythro commented 10 years ago

For IE debugging you may use http://modern.ie/en-us/virtualization-tools#downloads - legally and for free. Anyway, I'm planning to use lib for my FE stuff, so plan to check what's there with IE9+ this week. I've spent a lot of time to support older versions, but now no reason to make almost all of users suffer because of checks and workarounds.

nicolafranchini commented 10 years ago

Thank you @z-ax for your contribution. unfortunately the "pretty easy way" like BrowserStack is not good for debugging, so i'm trying to download 4GB!!! of Microsoft stuff and to install a virtual machine.. :( :( :( @matthewcarleton , I totally agree: is too bad that microsoft for years released a browser outside of web standards.. ;)

matthewcarleton commented 10 years ago

ya it's a sad reality that if we want to produce client facing code it will have to work even in the worst of current browsers.

I got parallels and installed win 7. It does the trick.

nicolafranchini commented 10 years ago

ok guys, script updated with IE support: tested on IE7, IE8, IE9.
basicly Explorer 9 or lower does not support css-animations, so the script wasn't calling his second function.
IE8 is still a little buggy with overlay background during gallery navigation (it loses the background color)
IE7 does not fully fit the window with background overlay

maaarshallmooore commented 10 years ago

For IE8, putting this in an ie8 stylesheet worked for me:

div.vbox-overlay { background: url("/assets/img/lightbox-images/lightbox-overlay.png") repeat !important; }

The !important is probably the most... important part.