nicolaisingh / saveplace-pdf-view

Save place in pdf-view buffers for Emacs
GNU General Public License v3.0
25 stars 6 forks source link

Unable to kill emacs #8

Closed mtreca closed 1 year ago

mtreca commented 3 years ago

This issue is very similar to the one mentioned in #2, but I get a different error message and backtrace:

Debugger entered--Lisp error: (wrong-type-argument listp t)
  image-mode-winprops(nil)
  image-mode-window-get(page nil)
  pdf-view-bookmark-make-record()
  saveplace-pdf-view-to-alist(pdf-view-bookmark pdf-view-bookmark-make-record)
  saveplace-pdf-view-to-alist-advice(#f(compiled-function () #<bytecode 0x458ad843>))
  apply(saveplace-pdf-view-to-alist-advice #f(compiled-function () #<bytecode 0x458ad843>) nil)
  save-place-to-alist()
  save-places-to-alist()
  save-place-kill-emacs-hook()
  kill-emacs()
  save-buffers-kill-emacs(nil)
  save-buffers-kill-terminal(nil)
  funcall-interactively(save-buffers-kill-terminal nil)
  call-interactively(save-buffers-kill-terminal nil nil)
  command-execute(save-buffers-kill-terminal)

I am on Emacs-mac 27.2. I will try to get a minimal way to reproduce the issue at some point.

nicolaisingh commented 3 years ago

hi, so far I'm not able to reproduce this issue. does this occur 100% of the time? and I'm assuming this happens when exiting emacs?

i'm not yet sure, but the problem might be in pdf-view or image-mode based on the trace above.

mtreca commented 3 years ago

It does occur rarely, and the issue is that I am not sure what triggers it exactly. My hint is that it has to do with broken or invalid PDFs since I tend to generate quite a lot of those within Emacs. I will post a recipe to recreate this issue if I ever manage to isolate it.

nicolaisingh commented 1 year ago

Closing.