search

nicolaka / ddc-aws

Docker Data Center on AWS
Apache License 2.0
11 stars 5 forks source link

fixes dependency errors, renames controller to master #5

Closed bchav closed 8 years ago

bchav commented 8 years ago

This stack launches now. We had dependency errors preventing it from passing initial CFN validation.

I renamed "controller" to "Master" because everything else in the template referenced "Master".

nicolaka commented 8 years ago

@bchav i fixed the dependencies issue. I want to stick to controller because that's the name used in the bootstrapper. So changed it to controller everywhere. For UCP it will be : controller, replica( x2), node

I dont think this CFN will work today but we have a new release tomorrow that should make it work.

bchav commented 8 years ago

This PR, before your changes, did fix the dependency errors and the stack launched. I can re-name Master to Controller no problem.

nicolaka commented 8 years ago

yea sorry i just made the changes. The master branch should have the correct naming. The reason why it wouldn't work now is that i'm depending on a feature to abstract the fingerprint from the controller using curl. But the controller node should come up just fine. It's the node asg that wont work properly until thursday.

nicolaka commented 8 years ago

So I suggest just closing the PR because I updated the file already.