search

nicolas-besnard / adminlte2-rails

MIT License
104 stars 57 forks source link

Updated to Admin LTE 2.3 #8

Open henkesn opened 9 years ago

henkesn commented 9 years ago

Hi Nicolas,

thank you for your great gem. I forked it and updated the AdminLTE version to 2.3. Also I updated the js plugins when there were new versions. I haven't touched the gemspec as I think it's up to you to decide if this is a new version ;o)

Regards Basti

nicolas-besnard commented 9 years ago

Hi !

Thanks or that your PR. What a terrible idea it was to include all this JS / CSS... It's nearly impossible to maintain this. I should try an other solution.

henkesn commented 9 years ago

Yeah, perhaps it would have been better to include the plugins as separate gems. Many of them exist already.

nicolas-besnard commented 9 years ago

the problem is that if a gem is no longer maintained, you'll have deprecated libraries.

On Fri, Sep 11, 2015 at 1:42 PM henkesn notifications@github.com wrote:

Yeah, perhaps it would have been better to include the plugins as separate gems. Many of them exist already.

— Reply to this email directly or view it on GitHub https://github.com/nicolas-besnard/adminlte2-rails/pull/8#issuecomment-139523104 .

Nicolas

cpg commented 9 years ago

I created a new AdminLTE gem using the original files (using the 2.3 release), so that it's easier to maintain. As you found out, it's hard to maintain if you make modifications.

So far the CSS is working well. Need to work on the JS integration.

cpg commented 9 years ago

I should point out this is the first time I work on a gem with assets, so I could well be doing something quite badly :100:

I would like to keep maintaining it because I use the theme in production.

nicolas-besnard commented 9 years ago

@cpg I didn't think your solution is the best to manage AdminLTE. I think mine is not the best too.

I'll try to create a better gem when I'll find the time to do it.