nicolas-raoul / jakaroma

Java library and command-line tool to transliterate Japanese kanji to romaji (Latin alphabet)
Apache License 2.0
62 stars 8 forks source link

Mavenization, junit 4.12 is added, some refactoring. #11

Closed ravingbool closed 3 years ago

ravingbool commented 3 years ago

Please create a public repo called https://github.com/nicolas-raoul/OSSRH-65862 to verify github account ownership. It is needed due to https://issues.sonatype.org/browse/OSSRH-65862

ravingbool commented 3 years ago

can I add some special symbols translation to KanaToRomaji.java? aMap.put("「", "\""); aMap.put("」", "\""); aMap.put("。", ".");

ravingbool commented 3 years ago

Hello @nicolas-raoul please take a look again, I fixed the issues :)

nicolas-raoul commented 3 years ago

Thanks a lot! Please do not hesitate to fix any other issue, also the unit tests probably need some maintenance :-)

ravingbool commented 3 years ago

Thank you for the quick response @nicolas-raoul! Have a tice day! Max