search

nicolas-steenhout / main

For my main site - jekyll and gh pages
MIT License
0 stars 2 forks source link

Contrast for menu items #31

Closed vavroom closed 1 month ago

vavroom commented 1 month ago

Just calculated the contrast ratio between the links and background. I get 3:01. Which only just squeezes by as it's large text.

But my eyes are tired this morning and I was struggling a bit to see them.

How do you feel about making the link text a bit lighter, so the contrast is a bit stronger?

digilou commented 1 month ago

It may be the visited link text throwing it. But I will adjust where needed. Contrast it's important but I've rushed the color palette and implementation a bit.

vavroom commented 1 month ago

Ahhh, yes, I think you got it - I am looking at the menu now, and the only link I haven't visited is /book. And that one stands out. Good call!

digilou commented 1 month ago

On that note, I'm pretty confident dark mode choices may be low. But will address that before completion. If you spy any bad contrast, please do note it so I can tackle it quickly.

vavroom commented 1 month ago

If we miss it, I'm pretty sure Alicia will pick up on it. This is the entire idea behind having a non-involved pair of eyes check for us, and keep us honest :D