search

nicolas-steenhout / main

For my main site - jekyll and gh pages
MIT License
0 stars 2 forks source link

figure/figcaption for testimonials may be wrong markup #85

Open vavroom opened 3 weeks ago

vavroom commented 3 weeks ago

◦ Not sure why the testimonial authors are figcaptions for figures. You’re already using blockquote. I’d think use cite for the authors, no? For JAWS, using figure means you have annoying “has details” announcements before and after the figure. See bug: https://github.com/FreedomScientific/standards-support/issues/657

vavroom commented 3 weeks ago

@digilou Just FYI - this is something I need to ponder quickly as it may have an impact on your styling.

digilou commented 1 week ago

@vavroom Once you've figured this out, you should be able to adjust styling easily (hopefully).

digilou commented 1 week ago

@vavroom 'cite' is something else entirely, though its name sure would imply this is the case!

Cite element = citing the name of a work

digilou commented 1 week ago

Maybe you were thinking Scott's How Do You Figure? article?

vavroom commented 5 days ago

@digilou I'd already told Alicia that her suggestion to use <cite> wasn't semantically correct :) I might just go with a blockquote and regular text or a span or something. Still pondering this.